Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1430633006: Fix exception location in z7 test on older bots (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Fix exception location in z7 test on older bots The cdb on the x86 bot displays relative to exported DLL symbols, but newer ones don't seem to, so it's either: z7_test!CrashMe+0xe or z7_test+0x100e https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x86_rel/builds/110/steps/run%20tests/logs/stdio R=mark@chromium.org BUG=crashpad:47 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c295e9d7487ab6a3a7f827c4464efacb9c3bb091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M snapshot/win/end_to_end_test.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 1 month ago (2015-11-02 17:33:16 UTC) #1
Mark Mentovai
LGTM
5 years, 1 month ago (2015-11-02 18:25:50 UTC) #2
scottmg
5 years, 1 month ago (2015-11-02 18:28:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c295e9d7487ab6a3a7f827c4464efacb9c3bb091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698