Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1430633002: Use --gtest_flagfile for --gtest_filter in unit test launcher (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
sky, Jamie Madill
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use --gtest_flagfile for --gtest_filter in unit test launcher This should help with exceeding command line length limits with long filter strings when running a lot of tests in the same batch. BUG=509883 Committed: https://crrev.com/d6c9c836e856b3d223747464f82b5586778ffc73 Cr-Commit-Position: refs/heads/master@{#356941}

Patch Set 1 #

Patch Set 2 : trybots #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M base/test/launcher/test_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 2 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-10-29 12:31:43 UTC) #2
Jamie Madill
I tested this CL locally with angle_deqp_gles2_tests and a patch to give them much longer ...
5 years, 1 month ago (2015-10-29 16:06:26 UTC) #4
sky
LGTM assuming the builders still show the tests being run. https://codereview.chromium.org/1430633002/diff/20001/base/test/launcher/unit_test_launcher.cc File base/test/launcher/unit_test_launcher.cc (right): https://codereview.chromium.org/1430633002/diff/20001/base/test/launcher/unit_test_launcher.cc#newcode116 ...
5 years, 1 month ago (2015-10-29 17:32:34 UTC) #5
Paweł Hajdan Jr.
https://codereview.chromium.org/1430633002/diff/20001/base/test/launcher/unit_test_launcher.cc File base/test/launcher/unit_test_launcher.cc (right): https://codereview.chromium.org/1430633002/diff/20001/base/test/launcher/unit_test_launcher.cc#newcode116 base/test/launcher/unit_test_launcher.cc:116: if (!temp_dir_.IsValid()) { On 2015/10/29 at 17:32:34, sky wrote: ...
5 years, 1 month ago (2015-10-29 18:43:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430633002/40001
5 years, 1 month ago (2015-10-29 18:44:18 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-29 20:56:02 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 20:57:16 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d6c9c836e856b3d223747464f82b5586778ffc73
Cr-Commit-Position: refs/heads/master@{#356941}

Powered by Google App Engine
This is Rietveld 408576698