blimp: Add support for input handling

blimp/client/input/blimp_input_manager.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/client/input/blimp_input_manager.h"
+
+#include "base/bind.h"
+#include "base/location.h"
+#include "ui/events/blink/blink_event_util.h"
+#include "ui/events/gesture_detection/gesture_provider_config_helper.h"
+#include "ui/events/gestures/blink/web_gesture_curve_impl.h"
+
+namespace blimp {
+
+scoped_ptr<BlimpInputManager> BlimpInputManager::Create(
+      BlimpInputManagerClient* client,
+      scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
+      scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner,
+      const base::WeakPtr<cc::InputHandler>& input_handler) {
+  return make_scoped_ptr(new BlimpInputManager(client,
+                                               main_task_runner,
+                                               compositor_task_runner,
+                                               input_handler));
+}
+
+BlimpInputManager::BlimpInputManager(
+    BlimpInputManagerClient* client,
+    scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
+    scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner,
+    const base::WeakPtr<cc::InputHandler>& input_handler)
+    : client_(client),
+      main_task_runner_(main_task_runner),
+      compositor_task_runner_(compositor_task_runner),
+      gesture_provider_(ui::GetGestureProviderConfig(
+          ui::GestureProviderConfigType::CURRENT_PLATFORM),
+                        this) {
+  DCHECK(IsMainThread());
+  DCHECK(client_);
+  compositor_task_runner_->PostTask(
+      FROM_HERE,
+      base::Bind(
+          &BlimpInputManager::CreateInputHandlerProxyOnCompositorThread,
+          base::Unretained(this), input_handler));

[David Trainor- moved to gerrit, 2015/12/02 03:49:06]

Are we sure we want unretained for this?  Unretained means no internal ref
counting or safety IIUC (I might be wrong though).  Don't we need a weak factory
and weak pointers?  Or is it guaranteed that we can't post a task and destroy
the object after?

Same for all other instances.

[Khushal, 2015/12/03 11:31:38]

You're right, its not safe to use Unretained for these calls. I have changed the
shutdown sequence so we can use Unretained for tasks posted on the compositor
thread, since we block on Shutdown to make sure that the input manager can not
be called on the compositor thread after being destroyed. And added a weak ptr
factory to post tasks to the main thread.

Another approach that would avoid blocking the main thread would be to have a
weak factory for the compositor thread and post a task on the main thread when
we build the input handler proxy and pass the weak ptr from this factory that it
can use to post tasks on the compositor thread. This way the main thread will
just drop the input events till it is notified that the input handler proxy is
created and it gets this weak ptr. And we can destroy this weak factory in
WillShutdown() to ensure the pointers are invalidated on the compositor thread.
Would that be better?

[Khushal, 2015/12/03 12:44:30]

Looking at this again, we'll still need to post a task to create the input
handler proxy on the compositor thread. So I guess the destruction has to be
blocking. :/

+}
+
+BlimpInputManager::~BlimpInputManager() {
+  DCHECK(IsMainThread());
+}
+
+bool BlimpInputManager::OnTouchEvent(const ui::MotionEvent& motion_event) {
+  DCHECK(IsMainThread());
+
+  ui::FilteredGestureProvider::TouchHandlingResult result =
+      gesture_provider_.OnTouchEvent(motion_event);
+  if (!result.succeeded)
+    return false;
+
+  blink::WebTouchEvent touch =
+      ui::CreateWebTouchEventFromMotionEvent(motion_event,
+                                             result.did_generate_scroll);
+
+  // Touch events are queued in the Gesture Provider until acknowledged to
+  // allow them to be consumed by the touch event handlers in blink which can
+  // prevent-default on the event. Since we currently do not support touch
+  // handlers the event is always acknowledged as not consumed.
+  gesture_provider_.OnTouchEventAck(touch.uniqueTouchEventId, false);
+
+  return true;
+}
+
+void BlimpInputManager::WillShutdown() {
+  DCHECK(IsCompositorThread());
+
+  input_handler_proxy_.reset();
+}
+
+void BlimpInputManager::TransferActiveWheelFlingAnimation(
+    const blink::WebActiveWheelFlingParameters& params) {
+  DCHECK(IsCompositorThread());
+
+  NOTIMPLEMENTED()<<

[David Trainor- moved to gerrit, 2015/12/02 03:49:06]

space between () and <<?

[Khushal, 2015/12/03 11:31:38]

Done.

+      "Transferring Fling Animations to the engine is not supported";
+}
+
+blink::WebGestureCurve* BlimpInputManager::CreateFlingAnimationCurve(
+      blink::WebGestureDevice device_source,
+      const blink::WebFloatPoint& velocity,
+      const blink::WebSize& cumulative_scroll) {
+  DCHECK(IsCompositorThread());
+
+  return ui::WebGestureCurveImpl::CreateFromDefaultPlatformCurve(
+               gfx::Vector2dF(velocity.x, velocity.y),
+               gfx::Vector2dF(cumulative_scroll.width,
+                              cumulative_scroll.height),
+               false /* on_main_thread */).release();
+}
+
+void BlimpInputManager::DidOverscroll(
+    const gfx::Vector2dF& accumulated_overscroll,
+    const gfx::Vector2dF& latest_overscroll_delta,
+    const gfx::Vector2dF& current_fling_velocity,
+    const gfx::PointF& causal_event_viewport_point) {
+  DCHECK(IsCompositorThread());
+}
+
+void BlimpInputManager::DidStopFlinging() {
+  DCHECK(IsCompositorThread());
+}
+
+void BlimpInputManager::DidAnimateForInput() {
+  DCHECK(IsCompositorThread());
+}
+
+void BlimpInputManager::OnGestureEvent(const ui::GestureEventData& gesture) {
+  DCHECK(IsMainThread());
+
+  blink::WebGestureEvent web_gesture =
+      ui::CreateWebGestureEventFromGestureEventData(gesture);
+  // TODO(jdduke): Remove this workaround after Android fixes UiAutomator to
+  // stop providing shift meta values to synthetic MotionEvents. This prevents
+  // unintended shift+click interpretation of all accessibility clicks.
+  // See crbug.com/443247.
+  if (web_gesture.type == blink::WebInputEvent::GestureTap &&
+      web_gesture.modifiers == blink::WebInputEvent::ShiftKey) {
+    web_gesture.modifiers = 0;
+  }
+
+  compositor_task_runner_->PostTask(
+      FROM_HERE,
+      base::Bind(
+          &BlimpInputManager::HandleWebInputEventOnCompositorThread,
+          base::Unretained(this), web_gesture));
+}
+
+void BlimpInputManager::CreateInputHandlerProxyOnCompositorThread(
+    const base::WeakPtr<cc::InputHandler>& input_handler) {
+  DCHECK(IsCompositorThread());
+
+  // The input_handler might have been destroyed at this point.
+  if (!input_handler)
+    return;
+
+  DCHECK(!input_handler_proxy_);
+  input_handler_proxy_ =
+      make_scoped_ptr(new ui::InputHandlerProxy(input_handler.get(), this));
+}
+
+void BlimpInputManager::HandleWebInputEventOnCompositorThread(
+      const blink::WebInputEvent& input_event) {
+  DCHECK(IsCompositorThread());
+
+  // We might not have the input handler proxy anymore.
+  if (!input_handler_proxy_)
+    return;
+
+  ui::InputHandlerProxy::EventDisposition disposition =
+      input_handler_proxy_->HandleInputEvent(input_event);
+
+  if (disposition == ui::InputHandlerProxy::DID_NOT_HANDLE) {
+    main_task_runner_->PostTask(
+        FROM_HERE,
+        base::Bind(&BlimpInputManager::SendWebInputEvent,
+                   base::Unretained(this), input_event));
+  }
+}
+
+void BlimpInputManager::SendWebInputEvent(
+    const blink::WebInputEvent& input_event) {
+  DCHECK(IsMainThread());
+
+  client_->SendWebInputEvent(input_event);
+}
+
+bool BlimpInputManager::IsMainThread() const {
+  return main_task_runner_->BelongsToCurrentThread();
+}
+
+bool BlimpInputManager::IsCompositorThread() const {
+  return compositor_task_runner_->BelongsToCurrentThread();
+}
+
+}  // namespace blimp