Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 14306006: Roll Skia DEPS to r8815 (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
chromium-reviews, skia-team_google.com, Raphael Kubo da Costa (rakuco)
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
robertphillips
control: https://codereview.chromium.org/13934017/
7 years, 8 months ago (2013-04-23 11:49:54 UTC) #1
robertphillips
I believe this is "good-ish". W.r.t. layout tests we would be rolling solely on the ...
7 years, 8 months ago (2013-04-23 11:52:11 UTC) #2
bsalomon
lgtm On Tue, Apr 23, 2013 at 7:52 AM, <robertphillips@google.com> wrote: > I believe this ...
7 years, 8 months ago (2013-04-23 13:16:24 UTC) #3
reed1
lgtm
7 years, 8 months ago (2013-04-23 13:17:22 UTC) #4
robertphillips
Committed patchset #1 manually as r195784 (presubmit successful).
7 years, 8 months ago (2013-04-23 13:42:44 UTC) #5
robertphillips
reverted in 195808 due to linux layout test crashes
7 years, 8 months ago (2013-04-23 16:16:45 UTC) #6
robertphillips
The linux_layout try and the real bot overlapped on 93 out of 95/97 crashes. The ...
7 years, 8 months ago (2013-04-23 16:18:07 UTC) #7
reed1
working on fix...
7 years, 8 months ago (2013-04-23 16:28:18 UTC) #8
reed1
7 years, 8 months ago (2013-04-23 16:36:18 UTC) #9
Message was sent while issue was closed.
believe fixed in 8830

Powered by Google App Engine
This is Rietveld 408576698