|
|
Chromium Code Reviews|
Created:
7 years, 8 months ago by robertphillips Modified:
7 years, 8 months ago CC:
chromium-reviews, skia-team_google.com, Raphael Kubo da Costa (rakuco) Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionRoll Skia DEPS to r8815
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195784
Patch Set 1 #Messages
Total messages: 9 (0 generated)
I believe this is "good-ish". W.r.t. layout tests we would be rolling solely on
the strength of the mac_layout tests "passing". The discrepancies between the
roll and the control are:
linux_heapcheck
roll:
heapcheck test: printing crashed or hung
heapcheck test: media crashed or hung
heapcheck test: courgette_unittests crashed or hung
heapcheck test: sync crashed or hung
heapcheck test: ui_unittests crashed or hung
heapcheck test: unit crashed or hung
heapcheck test: test_shell crashed or hung
control:
compile failed
mac_asan
roll:
compile failed - GOMA failure
control:
compile failed - GOMA failure
win
roll:
update_scripts failed
media_unittests 18 disabled did not complete failed 13
DisableAudioStream
Read_Audio
Read_EndOfStream
Read_EndOfStream_NoDuration
Read_Video
Read_VideoNonZeroStart
Seek
SeekWithCuesBeforeFirstCluster
BasicPlayback
BasicPlaybackHashed
BasicPlayback_16x9AspectRatio
BasicPlayback_AudioOnly_Opus_WebM
BasicPlayback_VP8A_WebM
control:
green
win_gpu
roll:
compile failed - link error on "WTF::operator<<"
control:
compile failed - link error on "WTF::operator<<"
linux_layout
roll:
webkit_tests 3193 fixable (0 skipped) failed 105
Regressions: Unexpected text-only failures (5)
Regressions: Unexpected crashes (95)
- mainly virtual/gpu/*
Regressions: Unexpected timeouts (5)
control:
webkit_tests 1804 fixable (0 skipped) failed 61
Regressions: Unexpected text-only failures (4)
Regressions: Unexpected crashes (5)
Regressions: Unexpected timeouts (44)
- mainly webaudio/*
Regressions: Unexpected missing results (8)
linux_layout_rel - unfortunately the 97 crashed don't match!
roll:
webkit_tests 3339 fixable (0 skipped) failed 100
Regressions: Unexpected crashes (97)
Regressions: Unexpected timeouts (3)
control:
webkit_tests 5772 fixable (0 skipped) failed 100
Regressions: Unexpected crashes (97)
Regressions: Unexpected timeouts (3)
mac_layout_rel
roll:
compile failed - missing file in Blink - not Skia-related
control:
webkit_unit_tests 11 disabled failed 2
setContentsToSolidColor
GraphicsLayerBackgroundColor
webkit_tests 1667 fixable (0 skipped) failed 100
Regressions: Unexpected text-only failures (87)
- mainly virtual/softwarecompositing/*
Regressions: Unexpected image-only failures (10)
Regressions: Unexpected crashes (2)
Regressions: Unexpected timeouts (1)
win_layout
roll:
gclient hooks failed
control:
compile failed - 'avoidScrollbarCreation' not found in Blink
win_layout_rel
roll:
compile failed - link error on "WTF::operator<<"
control:
compile failed - link error on "WTF::operator<<"
lgtm On Tue, Apr 23, 2013 at 7:52 AM, <robertphillips@google.com> wrote: > I believe this is "good-ish". W.r.t. layout tests we would be rolling > solely on > the strength of the mac_layout tests "passing". The discrepancies between > the > roll and the control are: > > linux_heapcheck > roll: > heapcheck test: printing crashed or hung > heapcheck test: media crashed or hung > heapcheck test: courgette_unittests crashed or hung > heapcheck test: sync crashed or hung > heapcheck test: ui_unittests crashed or hung > heapcheck test: unit crashed or hung > heapcheck test: test_shell crashed or hung > control: > compile failed > > mac_asan > roll: > compile failed - GOMA failure > control: > compile failed - GOMA failure > > win > roll: > update_scripts failed > media_unittests 18 disabled did not complete failed 13 > DisableAudioStream > Read_Audio > Read_EndOfStream > Read_EndOfStream_NoDuration > Read_Video > Read_VideoNonZeroStart > Seek > SeekWithCuesBeforeFirstCluster > BasicPlayback > BasicPlaybackHashed > BasicPlayback_16x9AspectRatio > BasicPlayback_AudioOnly_Opus_**WebM > BasicPlayback_VP8A_WebM > control: > green > > win_gpu > roll: > compile failed - link error on "WTF::operator<<" > control: > compile failed - link error on "WTF::operator<<" > > linux_layout > roll: > webkit_tests 3193 fixable (0 skipped) failed 105 > Regressions: Unexpected text-only failures (5) > Regressions: Unexpected crashes (95) > - mainly virtual/gpu/* > Regressions: Unexpected timeouts (5) > control: > webkit_tests 1804 fixable (0 skipped) failed 61 > Regressions: Unexpected text-only failures (4) > Regressions: Unexpected crashes (5) > Regressions: Unexpected timeouts (44) > - mainly webaudio/* > Regressions: Unexpected missing results (8) > > linux_layout_rel - unfortunately the 97 crashed don't match! > roll: > webkit_tests 3339 fixable (0 skipped) failed 100 > Regressions: Unexpected crashes (97) > Regressions: Unexpected timeouts (3) > control: > webkit_tests 5772 fixable (0 skipped) failed 100 > Regressions: Unexpected crashes (97) > Regressions: Unexpected timeouts (3) > > mac_layout_rel > roll: > compile failed - missing file in Blink - not Skia-related > control: > webkit_unit_tests 11 disabled failed 2 > setContentsToSolidColor > GraphicsLayerBackgroundColor > webkit_tests 1667 fixable (0 skipped) failed 100 > Regressions: Unexpected text-only failures (87) > - mainly virtual/softwarecompositing/* > Regressions: Unexpected image-only failures (10) > Regressions: Unexpected crashes (2) > Regressions: Unexpected timeouts (1) > > win_layout > roll: > gclient hooks failed > control: > compile failed - 'avoidScrollbarCreation' not found in Blink > > win_layout_rel > roll: > compile failed - link error on "WTF::operator<<" > control: > compile failed - link error on "WTF::operator<<" > > > > > https://codereview.chromium.**org/14306006/<https://codereview.chromium.org/1... >
lgtm
Message was sent while issue was closed.
Committed patchset #1 manually as r195784 (presubmit successful).
Message was sent while issue was closed.
reverted in 195808 due to linux layout test crashes
Message was sent while issue was closed.
The linux_layout try and the real bot overlapped on 93 out of 95/97 crashes. The linux_layout_rel try and the real bot overlapped on 80 of the 97 crashes
Message was sent while issue was closed.
working on fix...
Message was sent while issue was closed.
believe fixed in 8830 |
