Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: chrome/browser/chromeos/login/user_manager_impl.cc

Issue 14306004: Put Kiosk App parameters into device settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/user_manager_impl.cc b/chrome/browser/chromeos/login/user_manager_impl.cc
index ca3c7b4bb909c8303d2d383183d8169034c1f4e9..45978345b6bd12c3611b4ecdf4f458910356bd8f 100644
--- a/chrome/browser/chromeos/login/user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/user_manager_impl.cc
@@ -835,8 +835,8 @@ void UserManagerImpl::EnsureUsersLoaded() {
for (std::vector<std::string>::const_iterator it = regular_users.begin();
it != regular_users.end(); ++it) {
User* user = NULL;
- if (gaia::ExtractDomainName(*it) ==
- UserManager::kLocallyManagedUserDomain) {
+ const std::string domain_name = gaia::ExtractDomainName(*it);
+ if (domain_name == UserManager::kLocallyManagedUserDomain) {
user = User::CreateLocallyManagedUser(*it);
} else {
user = User::CreateRegularUser(*it);
@@ -885,12 +885,29 @@ void UserManagerImpl::RetrieveTrustedDevicePolicies() {
cros_settings_->GetBoolean(kAccountsPrefEphemeralUsersEnabled,
&ephemeral_users_enabled_);
cros_settings_->GetString(kDeviceOwner, &owner_email_);
- const base::ListValue* public_accounts;
- cros_settings_->GetList(kAccountsPrefDeviceLocalAccounts, &public_accounts);
+ const base::ListValue* device_local_accounts;
+ base::ListValue public_accounts;
+ if (cros_settings_->GetList(kAccountsPrefDeviceLocalAccounts,
+ &device_local_accounts)) {
+ for (base::ListValue::const_iterator user(device_local_accounts->begin());
+ user != device_local_accounts->end(); ++user) {
+ std::string user_id;
+ if (!(*user)->GetAsString(&user_id))
+ continue;
+ const std::string domain = gaia::ExtractDomainName(user_id);
+ if (domain == kKioskAppUserDomain) {
+ // TODO(mnissler, nkostylev, bartfab): Process Kiosk Apps within the
+ // standard user framework.
+ continue;
+ } else {
+ public_accounts.AppendString(user_id);
+ }
+ }
+ }
EnsureUsersLoaded();
- bool changed = UpdateAndCleanUpPublicAccounts(*public_accounts);
+ bool changed = UpdateAndCleanUpPublicAccounts(public_accounts);
// If ephemeral users are enabled and we are on the login screen, take this
// opportunity to clean up by removing all regular users except the owner.

Powered by Google App Engine
This is Rietveld 408576698