Put Kiosk App parameters into device settings.

chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_policy_decoder_chromeos.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/values.h"
-#include "chrome/browser/chromeos/policy/app_pack_updater.h"
 #include "chrome/browser/chromeos/policy/enterprise_install_attributes.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
 #include "chrome/browser/chromeos/settings/cros_settings_names.h"
 #include "chrome/browser/policy/policy_map.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/update_engine_client.h"
 #include "policy/policy_constants.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 using google::protobuf::RepeatedField;
@@ skipping 93 matching lines @@
                         container.ephemeral_users_enabled()));
     }
   }
 
   if (policy.has_device_local_accounts()) {
     const em::DeviceLocalAccountsProto& container(
         policy.device_local_accounts());
     const RepeatedPtrField<em::DeviceLocalAccountInfoProto>& accounts =
         container.account();
     if (accounts.size() > 0) {
-      ListValue* account_list = new ListValue();
+      scoped_ptr<base::DictionaryValue> account_dict(

[bartfab (slow), 2013/04/25 11:17:28]

1/ Nit: #include "base/memory/scoped_ptr.h"

2/  Why use a scoped_ptr if you will pass ownership unconditionally anyway?

[Mattias Nissler (ping if slow), 2013/04/26 09:10:05]

1/ Done.
2/ Habit to avoid memory leaks.

+          new base::DictionaryValue());
       RepeatedPtrField<em::DeviceLocalAccountInfoProto>::const_iterator entry;
       for (entry = accounts.begin(); entry != accounts.end(); ++entry) {
-        if (entry->has_id())
-          account_list->AppendString(entry->id());
+        if (entry->id().empty() || account_dict->HasKey(entry->id()))
+          continue;
+
+        scoped_ptr<base::DictionaryValue> entry_dict(

[bartfab (slow), 2013/04/25 11:17:28]

Why use a scoped_ptr if you will pass ownership unconditionally anyway?

[Mattias Nissler (ping if slow), 2013/04/26 09:10:05]

See above

+            new base::DictionaryValue());
+        if (entry->has_kiosk_app_id()) {
+          entry_dict->SetStringWithoutPathExpansion(
+              chromeos::kAccountsPrefDeviceLocalAccountsKeyKioskAppId,
+              entry->kiosk_app_id());
+        }
+        if (entry->has_kiosk_app_update_url()) {
+          entry_dict->SetStringWithoutPathExpansion(
+              chromeos::kAccountsPrefDeviceLocalAccountsKeyKioskAppUpdateURL,
+              entry->kiosk_app_update_url());
+        }
+        account_dict->Set(entry->id(), entry_dict.release());
       }
       policies->Set(key::kDeviceLocalAccounts,
                     POLICY_LEVEL_MANDATORY,
                     POLICY_SCOPE_MACHINE,
-                    account_list);
+                    account_dict.release());
     }
     if (container.has_auto_login_id()) {
       policies->Set(key::kDeviceLocalAccountAutoLoginId,
                     POLICY_LEVEL_MANDATORY,
                     POLICY_SCOPE_MACHINE,
                     Value::CreateStringValue(container.auto_login_id()));
     }
     if (container.has_auto_login_delay()) {
       policies->Set(key::kDeviceLocalAccountAutoLoginDelay,
                     POLICY_LEVEL_MANDATORY,
                     POLICY_SCOPE_MACHINE,
                     DecodeIntegerValue(container.auto_login_delay()));
     }
+    if (container.has_enable_auto_login_bailout()) {
+      policies->Set(key::kDeviceLocalAccountAutoLoginBailoutEnabled,
+                    POLICY_LEVEL_MANDATORY,
+                    POLICY_SCOPE_MACHINE,
+                    Value::CreateBooleanValue(
+                        container.enable_auto_login_bailout()));
+    }
   }
 }
 
 void DecodeKioskPolicies(const em::ChromeDeviceSettingsProto& policy,
                          PolicyMap* policies,
                          EnterpriseInstallAttributes* install_attributes) {
   // No policies if this is not KIOSK.
   if (install_attributes->GetMode() != DEVICE_MODE_KIOSK)
     return;
 
@@ skipping 33 matching lines @@
     }
   }
 
   if (policy.has_app_pack()) {
     const em::AppPackProto& container(policy.app_pack());
     base::ListValue* app_pack_list = new base::ListValue();
     for (int i = 0; i < container.app_pack_size(); ++i) {
       const em::AppPackEntryProto& entry(container.app_pack(i));
       if (entry.has_extension_id() && entry.has_update_url()) {
         base::DictionaryValue* dict = new base::DictionaryValue();
-        dict->SetString(AppPackUpdater::kExtensionId, entry.extension_id());
-        dict->SetString(AppPackUpdater::kUpdateUrl, entry.update_url());
+        dict->SetString(chromeos::kAppPackKeyExtensionId, entry.extension_id());
+        dict->SetString(chromeos::kAppPackKeyUpdateUrl, entry.update_url());
         app_pack_list->Append(dict);
       }
     }
     policies->Set(key::kDeviceAppPack,
                   POLICY_LEVEL_MANDATORY,
                   POLICY_SCOPE_MACHINE,
                   app_pack_list);
   }
 
   if (policy.has_pinned_apps()) {
@@ skipping 280 matching lines @@
   // Decode the various groups of policies.
   DecodeLoginPolicies(policy, policies);
   DecodeKioskPolicies(policy, policies, install_attributes);
   DecodeNetworkPolicies(policy, policies, install_attributes);
   DecodeReportingPolicies(policy, policies);
   DecodeAutoUpdatePolicies(policy, policies);
   DecodeGenericPolicies(policy, policies);
 }
 
 }  // namespace policy