Issue 14306002: Make poor_mans_trybot support the component build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14306002: Make poor_mans_trybot support the component build. (Closed)

Created:
7 years, 8 months ago by grt (UTC plus 2)

Modified:
7 years, 8 months ago

Reviewers:
robertshield

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make poor_mans_trybot support the component build. It also now copies PDBs. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194424

Patch Set 2 : .ninja and .pch #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -40 lines)			Patch
	M	chrome_frame/test/poor_mans_trybot.bat	View		3 chunks	+65 lines, -27 lines	0 comments	Download
	M	chrome_frame/test/poor_mans_trybot_xcopy_filter.txt	View	1	1 chunk	+14 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertshield

LGTM https://codereview.chromium.org/14306002/diff/1/chrome_frame/test/poor_mans_trybot_xcopy_filter.txt File chrome_frame/test/poor_mans_trybot_xcopy_filter.txt (right): https://codereview.chromium.org/14306002/diff/1/chrome_frame/test/poor_mans_trybot_xcopy_filter.txt#newcode25 chrome_frame/test/poor_mans_trybot_xcopy_filter.txt:25: .gyp please add .pch and .ninja files here.

7 years, 8 months ago (2013-04-16 19:36:12 UTC) #2

grt (UTC plus 2)

Thanks. https://codereview.chromium.org/14306002/diff/1/chrome_frame/test/poor_mans_trybot_xcopy_filter.txt File chrome_frame/test/poor_mans_trybot_xcopy_filter.txt (right): https://codereview.chromium.org/14306002/diff/1/chrome_frame/test/poor_mans_trybot_xcopy_filter.txt#newcode25 chrome_frame/test/poor_mans_trybot_xcopy_filter.txt:25: .gyp On 2013/04/16 19:36:12, robertshield wrote: > please ...

7 years, 8 months ago (2013-04-16 19:55:23 UTC) #3

grt (UTC plus 2)

7 years, 8 months ago (2013-04-16 19:58:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194424 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14306002: Make poor_mans_trybot support the component build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : .ninja and .pch #

Messages