Issue 1430593005: EDK: Remove (direct) dependencies of //mojo/edk/system on //base/test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1430593005: EDK: Remove (direct) dependencies of //mojo/edk/system on //base/test. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Remove (direct) dependencies of //mojo/edk/system on //base/test. We still use //base/test for the moment, but only via things in //mojo/edk/system/test. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b7cd10b7e9200fa25dabde9f91ea7aaef351cbd1

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -51 lines)			Patch
M	mojo/edk/system/BUILD.gn	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	mojo/edk/system/channel_endpoint_unittest.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	mojo/edk/system/endpoint_relayer_unittest.cc	View	5 chunks	+10 lines, -5 lines	0 comments	Download
M	mojo/edk/system/ipc_support_unittest.cc	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	mojo/edk/system/message_pipe_perftest.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	mojo/edk/system/ref_counted_perftest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	mojo/edk/system/run_all_unittests.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	mojo/edk/system/test/BUILD.gn	View	3 chunks	+47 lines, -0 lines	0 comments	Download
A	mojo/edk/system/test/perf_log.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A +	mojo/edk/system/test/perf_log.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
A +	mojo/edk/system/test/run_all_perftests.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/edk/system/test/run_all_unittests.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-10-30 16:47:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b7cd10b7e9200fa25dabde9f91ea7aaef351cbd1 (presubmit successful).

Expand Messages | Collapse Messages