Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1430573006: ash: Fix memory leak in DisplayColorManager on error path (Closed)

Created:
5 years, 1 month ago by robert.bradford
Modified:
5 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Fix memory leak in DisplayColorManager on error path The error path for dealing with missing VCGT data was failing to free the loaded profile. Unfortunately due to https://crbug.com/549239 this error is occuring in the wild. The new unit tests at https://crrev.com/1430633003 cover this particular use case. BUG=None TEST=Inspection of error paths show no more leaks. Committed: https://crrev.com/f21f21fd88b6a96897c2678177383dfcbdf6f86a Cr-Commit-Position: refs/heads/master@{#357136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/display/display_color_manager_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robert.bradford
Hi oshima@ PTAL. I've triggered The ASan build on the new unit tests to see ...
5 years, 1 month ago (2015-10-30 15:39:05 UTC) #2
oshima
lgtm We just talked about this leak a few days back. Thank you for fixing!
5 years, 1 month ago (2015-10-30 16:49:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430573006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430573006/1
5 years, 1 month ago (2015-10-30 16:59:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 18:30:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:31:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f21f21fd88b6a96897c2678177383dfcbdf6f86a
Cr-Commit-Position: refs/heads/master@{#357136}

Powered by Google App Engine
This is Rietveld 408576698