Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1430553003: [turbofan] Use sorted set in JSInliningHeuristic. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use sorted set in JSInliningHeuristic. This changes the inlining candidates to be stored in a sorted set of unique entries instead of a vector. We can avoid the final sorting operation by amortizing the cost across insertions and also duplicate entries are not created in the first place. Duplicate entries cause crashes when candidates are processed. R=bmeurer@chromium.org BUG=chromium:549113 LOG=n Committed: https://crrev.com/2a4336d97ae8d22ba4955c083fa7f6e6f3740e35 Cr-Commit-Position: refs/heads/master@{#31742}

Patch Set 1 #

Patch Set 2 : Fix typo of doom. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M src/compiler/js-inlining-heuristic.h View 1 chunk +10 lines, -2 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-03 10:15:31 UTC) #1
Benedikt Meurer
LGTM :-)
5 years, 1 month ago (2015-11-03 10:16:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430553003/20001
5 years, 1 month ago (2015-11-03 11:27:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 11:29:04 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 11:29:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a4336d97ae8d22ba4955c083fa7f6e6f3740e35
Cr-Commit-Position: refs/heads/master@{#31742}

Powered by Google App Engine
This is Rietveld 408576698