Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1430533003: Merge to XFA: Revert "Add test case for parsing endobj keywords." (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Revert "Add test case for parsing endobj keywords." This reverts commit 5bd88ec07e79215400777f3095c6843e0627cade. (cherry picked from commit 97dd3fec106ac8a945e03ed1509af0a8b73da993) R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b85544053495270bb54b55c79124f5318737fc8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -789 lines) Patch
D testing/resources/pixel/endobj1.in View 1 chunk +0 lines, -60 lines 0 comments Download
D testing/resources/pixel/endobj10.in View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/resources/pixel/endobj10_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj11.in View 1 chunk +0 lines, -65 lines 0 comments Download
D testing/resources/pixel/endobj11_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj12.in View 1 chunk +0 lines, -65 lines 0 comments Download
D testing/resources/pixel/endobj12_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj13.in View 1 chunk +0 lines, -65 lines 0 comments Download
D testing/resources/pixel/endobj13_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj1_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj2.in View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/resources/pixel/endobj2_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj3.in View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/resources/pixel/endobj3_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj4.in View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/resources/pixel/endobj4_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj5.in View 1 chunk +0 lines, -60 lines 0 comments Download
D testing/resources/pixel/endobj5_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj6.in View 1 chunk +0 lines, -60 lines 0 comments Download
D testing/resources/pixel/endobj6_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj7.in View 1 chunk +0 lines, -60 lines 0 comments Download
D testing/resources/pixel/endobj7_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj8.in View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/resources/pixel/endobj8_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/endobj9.in View 1 chunk +0 lines, -59 lines 0 comments Download
D testing/resources/pixel/endobj9_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
PTAL. The files list looks right, but they cherry pick was complaining about files added. ...
5 years, 1 month ago (2015-10-28 20:20:11 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-10-28 20:26:33 UTC) #3
dsinclair
5 years, 1 month ago (2015-10-28 20:28:42 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b85544053495270bb54b55c79124f5318737fc8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698