Move code out of supported_cdm_versions.h

Move code out of supported_cdm_versions.h

In the future there will be additional code that use the functions in
supported_cdm_versions.h. To avoid duplicate definitions, move it into
a separate .cc file.

TEST=compiles

Committed: https://crrev.com/8587d27400b78d6b024c86fe970ff699fdf17885
Cr-Commit-Position: refs/heads/master@{#357726}

[jrummell, 2015-11-03 22:51:42]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2015-11-03 22:51:42]

PTAL

[xhwang, 2015-11-03 23:07:25]

lgtm % one comment

https://codereview.chromium.org/1430503004/diff/20001/media/cdm/supported_cdm...
File media/cdm/supported_cdm_versions.h (right):

https://codereview.chromium.org/1430503004/diff/20001/media/cdm/supported_cdm...
media/cdm/supported_cdm_versions.h:22: FUNCTION_EXPORT bool
IsSupportedCdmHostVersion(int version);
#undef FUNCTION_EXPORT after this to avoid any unexpected consequences.

[jrummell, 2015-11-03 23:51:40]

Thanks for the quick review.

https://codereview.chromium.org/1430503004/diff/20001/media/cdm/supported_cdm...
File media/cdm/supported_cdm_versions.h (right):

https://codereview.chromium.org/1430503004/diff/20001/media/cdm/supported_cdm...
media/cdm/supported_cdm_versions.h:22: FUNCTION_EXPORT bool
IsSupportedCdmHostVersion(int version);
On 2015/11/03 23:07:25, xhwang wrote:
> #undef FUNCTION_EXPORT after this to avoid any unexpected consequences.

Done.

[jrummell, 2015-11-03 23:51:49]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2015-11-03 23:51:49]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1430503004/#ps40001
(title: "#undef")

[commit-bot: I haz the power, 2015-11-03 23:54:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1430503004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1430503004/40001

[jrummell, 2015-11-04 00:00:42]

Description was changed from

==========
Move code out of supported_cdm_versions.h

In the future there will be additional code that use the functions in
supported_cdm_versions.h. To avoid duplicate code, move it into a
seperate .cc file. Plugins also use this code, so they need a copy to
avoid run-time dependencies.

TEST=compiles
==========

to

==========
Move code out of supported_cdm_versions.h

In the future there will be additional code that use the functions in
supported_cdm_versions.h. To avoid duplicate definitions, move it into
a separate .cc file.

TEST=compiles
==========

[commit-bot: I haz the power, 2015-11-04 01:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 01:00:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jrummell, 2015-11-04 01:20:43]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-11-04 01:24:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1430503004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1430503004/40001

[commit-bot: I haz the power, 2015-11-04 02:07:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-04 02:07:48]

Patchset 3 (id:??) landed as
https://crrev.com/8587d27400b78d6b024c86fe970ff699fdf17885
Cr-Commit-Position: refs/heads/master@{#357726}