Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 14305029: Accurate function prototypes for native calls from ARM simulator. (Closed)

Created:
7 years, 7 months ago by Brad Chen
Modified:
7 years, 7 months ago
Reviewers:
ulan, Jakob Kummerow
CC:
v8-dev, yangguo, yurys
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Accurate function prototypes for native calls from ARM simulator. This is a resubmit of codereview.chromium.org/13818012 with the following modifications: - src/x64/code-stubs-x64.cc for changes specific to Win64 calling conventions. - src/sampler.cc for Native Client support BUG=v8:2614 Committed: https://code.google.com/p/v8/source/detail?r=14491 Committed: https://code.google.com/p/v8/source/detail?r=14494

Patch Set 1 #

Patch Set 2 : Disable CPU profiler tests #

Patch Set 3 : Win64-specific fixes #

Patch Set 4 : Minor formatting change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -110 lines) Patch
M src/arguments.h View 1 chunk +12 lines, -9 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +70 lines, -66 lines 0 comments Download
M src/atomicops_internals_x86_gcc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 chunk +21 lines, -13 lines 0 comments Download
A + src/builtins-decls.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/sampler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 2 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Brad Chen
PTAL
7 years, 7 months ago (2013-04-27 00:58:15 UTC) #1
Dmitry Lomov (no reviews)
Unfortunately this does not fix mksnapshot on Win64. On 2013/04/27 00:58:15, Brad Chen wrote: > ...
7 years, 7 months ago (2013-04-29 07:33:41 UTC) #2
Brad Chen
On 2013/04/29 07:33:41, Dmitry Lomov (chromium) wrote: > Unfortunately this does not fix mksnapshot on ...
7 years, 7 months ago (2013-04-29 18:06:50 UTC) #3
Dmitry Lomov (no reviews)
LGTM. Validated on Win64. Will land On 2013/04/29 18:06:50, Brad Chen wrote: > On 2013/04/29 ...
7 years, 7 months ago (2013-04-30 11:12:00 UTC) #4
Dmitry Lomov (no reviews)
Committed patchset #4 manually as r14491 (presubmit successful).
7 years, 7 months ago (2013-04-30 11:16:51 UTC) #5
Dmitry Lomov (no reviews)
7 years, 7 months ago (2013-04-30 11:34:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r14494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698