Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issue 1430493002: Revert of Precisely determine Windows thread stack size. (Closed)

Created:
5 years, 1 month ago by caseq
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, oilpan-reviews, blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Precisely determine Windows thread stack size. (patchset #2 id:20001 of https://codereview.chromium.org/1409243011/ ) Reason for revert: This apparently caused HeapTest.TraceDeepEagerly to crash on all Win bots (here's an example build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/65297) Original issue's description: > Precisely determine Windows thread stack size. > > The Thread Information Block (TIB)'s StackLimit records the end of > the committed area of the thread's stack reservation, hence it cannot be > used to determine the overall size of the reserved stack. Switch to > a VirtualQuery() lookup instead, but taking care to cache the result per > thread so as to avoid calling overhead. > > R=haraken > BUG=546396 > > Committed: https://crrev.com/7a23dd77ae2fd895fac2b4dcd8a542f575b6d1ac > Cr-Commit-Position: refs/heads/master@{#356287} TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546396 Committed: https://crrev.com/36b8f5dcd71cb2af3d131ce68cd9141a52bed896 Cr-Commit-Position: refs/heads/master@{#356321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -34 lines) Patch
M third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
Created Revert of Precisely determine Windows thread stack size.
5 years, 1 month ago (2015-10-27 17:03:41 UTC) #1
haraken
LGTM
5 years, 1 month ago (2015-10-27 17:04:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430493002/1
5 years, 1 month ago (2015-10-27 17:05:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 17:07:08 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 17:09:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36b8f5dcd71cb2af3d131ce68cd9141a52bed896
Cr-Commit-Position: refs/heads/master@{#356321}

Powered by Google App Engine
This is Rietveld 408576698