Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1430433005: Minor fixes to the mDNS package (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
wibling
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor fixes to the mDNS package * Wrong type * Missing export R=wibling@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/3043bb812b03cd701e140edec066f3fc17811e9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/mdns/lib/mdns.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/mdns/lib/src/native_protocol_client.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-10 12:31:49 UTC) #1
wibling
lgtm
5 years, 1 month ago (2015-11-10 12:47:33 UTC) #2
Søren Gjesse
5 years, 1 month ago (2015-11-10 12:53:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3043bb812b03cd701e140edec066f3fc17811e9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698