Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1430403002: Disable preemptive batch preparation (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable preemptive batch preparation Preemptive batch preparation makes MultiDrawBuffer more difficult to implement. This CL disables it. BUG=skia:4094 Committed: https://skia.googlesource.com/skia/+/1f0e350af690044b2ba807893ac470800f8914a2

Patch Set 1 #

Patch Set 2 : Fix comment #

Patch Set 3 : Remove tracking of inline uploads #

Patch Set 4 : clean up #

Patch Set 5 : Disabled pre-emptive preparation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M src/gpu/GrBatchAtlas.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrBatchFlushState.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBatchFlushState.cpp View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
robertphillips
5 years, 1 month ago (2015-11-10 16:26:47 UTC) #3
robertphillips
PTAL - not much here anymore.
5 years, 1 month ago (2015-11-10 17:01:02 UTC) #5
joshualitt
On 2015/11/10 17:01:02, robertphillips wrote: > PTAL - not much here anymore. lgtm
5 years, 1 month ago (2015-11-10 17:01:44 UTC) #6
robertphillips
Ooops - you beat me to it. I've updated this patch to disable the pre-emptive ...
5 years, 1 month ago (2015-11-10 17:46:22 UTC) #8
joshualitt
On 2015/11/10 17:46:22, robertphillips wrote: > Ooops - you beat me to it. I've updated ...
5 years, 1 month ago (2015-11-10 17:52:50 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430403002/80001
5 years, 1 month ago (2015-11-10 18:07:36 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 18:18:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430403002/80001
5 years, 1 month ago (2015-11-10 18:19:05 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:19:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1f0e350af690044b2ba807893ac470800f8914a2

Powered by Google App Engine
This is Rietveld 408576698