Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1430333002: Fix Observatory by disabling WebSocket compression (Closed)

Created:
5 years, 1 month ago by Cutch
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Observatory by disabling WebSocket compression BUG= Committed: https://github.com/dart-lang/sdk/commit/019f89507a368799ef6892f807422acaeb744414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/bin/vmservice/server.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Cutch
5 years, 1 month ago (2015-11-09 21:26:00 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as 019f89507a368799ef6892f807422acaeb744414 (presubmit successful).
5 years, 1 month ago (2015-11-09 21:27:12 UTC) #4
rmacnak
lgtm
5 years, 1 month ago (2015-11-09 21:28:06 UTC) #5
kevmoo
On 2015/11/09 21:28:06, rmacnak wrote: > lgtm Question: if you were broken by the WebSocket ...
5 years, 1 month ago (2015-11-09 22:05:03 UTC) #6
Cutch
5 years, 1 month ago (2015-11-09 22:09:01 UTC) #7
Message was sent while issue was closed. 
On 2015/11/09 22:05:03, kevmoo wrote:
> On 2015/11/09 21:28:06, rmacnak wrote:
> > lgtm
> 
> Question: if you were broken by the WebSocket change, does that imply we have
a
> bad default?

A bad default or a buggy implementation of WebSocket compression. I'd prefer to
use compression but if it doesn't work with Chrome it's a non-starter.

Powered by Google App Engine
This is Rietveld 408576698