Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1430313003: Change MojoWebUIController to use mojo::StrongBindingSet. (Closed)

Created:
5 years, 1 month ago by Sam McNally
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), James Su, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-geolocation-untangle
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change MojoWebUIController to use mojo::StrongBindingSet.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -138 lines) Patch
M chrome/browser/ui/webui/engagement/site_engagement_ui.h View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 2 chunks +1 line, -56 lines 0 comments Download
A chrome/browser/ui/webui/engagement/site_engagement_ui_handler.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/engagement/site_engagement_ui_handler.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/mojo_web_ui_controller.h View 2 chunks +19 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/mojo_web_ui_controller.cc View 1 chunk +1 line, -6 lines 0 comments Download
D chrome/browser/ui/webui/mojo_web_ui_handler.h View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui.h View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1411063007 Patch 250001

Messages

Total messages: 9 (9 generated)
Sam McNally
Patchset #2 (id:20001) has been deleted
5 years ago (2015-11-30 02:27:43 UTC) #1
Sam McNally
Patchset #2 (id:40001) has been deleted
5 years ago (2015-11-30 02:32:47 UTC) #2
Sam McNally
Patchset #3 (id:80001) has been deleted
5 years ago (2015-11-30 02:35:20 UTC) #3
Sam McNally
Patchset #2 (id:60001) has been deleted
5 years ago (2015-11-30 02:44:11 UTC) #4
Sam McNally
Patchset #1 (id:1) has been deleted
5 years ago (2015-11-30 02:54:34 UTC) #5
Sam McNally
Patchset #1 (id:100001) has been deleted
5 years ago (2015-11-30 03:04:10 UTC) #6
Sam McNally
Patchset #1 (id:120001) has been deleted
5 years ago (2015-11-30 03:04:17 UTC) #7
Sam McNally
Description was changed from ========== Change MojoWebUIController to use mojo::ServiceSet. ========== to ========== Change MojoWebUIController ...
5 years ago (2015-12-07 02:41:44 UTC) #8
Sam McNally
5 years ago (2015-12-10 03:01:44 UTC) #9 
Patchset #1 (id:140001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698