Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1430313002: cc: Make sure to issue IsReadyToDraw when we're out of memory. (Closed)

Created:
5 years, 1 month ago by vmpstr
Modified:
5 years, 1 month ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make sure to issue IsReadyToDraw when we're out of memory. This patch ensures that when we run out of memory, we still issue both ready to activate and ready to draw signals. The activation signal was already there, since we rely on it to activate. However, we also rely on the draw signal in the browser to draw. This patch adds the missing signal. Instead of freezing, we will now checkerboard/drop quads. BUG=551983 R=reveman CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7b89137245b37365c8b09c4cd417b0946c59ae1c Cr-Commit-Position: refs/heads/master@{#358671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -19 lines) Patch
M cc/tiles/tile_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +29 lines, -19 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 3 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Please take a look.
5 years, 1 month ago (2015-11-09 19:22:34 UTC) #1
reveman
lgtm
5 years, 1 month ago (2015-11-09 20:34:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430313002/1
5 years, 1 month ago (2015-11-09 20:40:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 21:56:00 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 21:56:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b89137245b37365c8b09c4cd417b0946c59ae1c
Cr-Commit-Position: refs/heads/master@{#358671}

Powered by Google App Engine
This is Rietveld 408576698