Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1430293002: [heap] Preserve optimized code maps accross GCs. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Michael Hablich, Jakob Kummerow
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Preserve optimized code maps accross GCs. This disables the eager flushing of optimized code maps during full GCs and instead treats entries in those tables weakly by default. Note that for now entries are removed when one of its components dies. R=mvstanton@chromium.org Committed: https://crrev.com/7a1377aab2ba4e2c9a7d422b51f645cbbaec10c7 Cr-Commit-Position: refs/heads/master@{#32045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-09 17:26:11 UTC) #1
mvstanton
Yeah! LGTM.
5 years, 1 month ago (2015-11-10 08:43:50 UTC) #3
Michael Starzinger
As discussed offline: I will hold off from landing this until Monday till after the ...
5 years, 1 month ago (2015-11-10 09:04:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430293002/1
5 years, 1 month ago (2015-11-17 13:44:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 14:11:07 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a1377aab2ba4e2c9a7d422b51f645cbbaec10c7 Cr-Commit-Position: refs/heads/master@{#32045}
5 years, 1 month ago (2015-11-17 14:11:34 UTC) #8
Hannes Payer (out of office)
5 years, 1 month ago (2015-11-23 12:06:43 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1467213002/ by hpayer@chromium.org.

The reason for reverting is: Janks finalization of full GC..

Powered by Google App Engine
This is Rietveld 408576698