Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1430273004: Do some small cleanup in IceTLS.h and add some markup for doxygen (Closed)

Created:
5 years, 1 month ago by rkotlerimgtec
Modified:
5 years, 1 month ago
Reviewers:
Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : changes per stichnot comments on patch1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -29 lines) Patch
M src/IceTLS.h View 1 3 chunks +44 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rkotlerimgtec
5 years, 1 month ago (2015-11-09 22:07:02 UTC) #3
John
lgtm
5 years, 1 month ago (2015-11-09 22:36:58 UTC) #4
rkotlerimgtec
I am not able to check code in so someone else will need to manually ...
5 years, 1 month ago (2015-11-09 22:47:52 UTC) #5
Jim Stichnoth
https://codereview.chromium.org/1430273004/diff/1/src/IceTLS.h File src/IceTLS.h (right): https://codereview.chromium.org/1430273004/diff/1/src/IceTLS.h#newcode22 src/IceTLS.h:22: /// @defgroup /IceTLC Defines 5 macros for unifying thread_local ...
5 years, 1 month ago (2015-11-09 22:49:52 UTC) #6
Jim Stichnoth
Changed the reviewer list to use the right email for Karl.
5 years, 1 month ago (2015-11-09 22:53:04 UTC) #8
rkotlerimgtec
https://codereview.chromium.org/1430273004/diff/1/src/IceTLS.h File src/IceTLS.h (right): https://codereview.chromium.org/1430273004/diff/1/src/IceTLS.h#newcode22 src/IceTLS.h:22: /// @defgroup /IceTLC Defines 5 macros for unifying thread_local ...
5 years, 1 month ago (2015-11-09 23:59:50 UTC) #9
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-11-10 00:01:46 UTC) #10
Jim Stichnoth
5 years, 1 month ago (2015-11-10 00:53:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
af5d44c6560e3fcd9ccb9c1f094369b05fcb28ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698