Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1430233002: Cherry-pick upstream r237073 (Closed)

Created:
5 years, 1 month ago by Petr Hosek
Modified:
5 years, 1 month ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cherry-pick upstream r237073 Allow empty assembly string literal with -fno-gnu-inline-asm Empty assembly string will not introduce assembly code in the output binary and it is often used as a trick in the header to disable optimizations. It doesn't conflict with the purpose of the option so it is allowed with -fno-gnu-inline-asm flag. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@237073 91177308-0d34-0410-b5e6-96231b3b80d8 BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4333 R=dschuff@chromium.org Committed: 25662b2f69a0a33aeea5f88008df8d48525064ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M lib/Parse/ParseStmtAsm.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M lib/Parse/Parser.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M test/Parser/no-gnu-inline-asm.c View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Petr Hosek
5 years, 1 month ago (2015-11-07 23:01:38 UTC) #2
Derek Schuff
lgtm
5 years, 1 month ago (2015-11-11 22:42:38 UTC) #3
Petr Hosek
5 years, 1 month ago (2015-11-12 01:16:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
25662b2f69a0a33aeea5f88008df8d48525064ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698