Support multiple service instances with GLInProcessContext

android_webview/browser/in_process_view_renderer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_BROWSER_IN_PROCESS_VIEW_RENDERER_H_
 #define ANDROID_WEBVIEW_BROWSER_IN_PROCESS_VIEW_RENDERER_H_
 
 #include <string>
 
 #include "android_webview/browser/browser_view_renderer.h"
 #include "android_webview/browser/gl_view_renderer_manager.h"
 #include "base/cancelable_callback.h"
 #include "content/public/browser/android/synchronous_compositor.h"
 #include "content/public/browser/android/synchronous_compositor_client.h"
+#include "gpu/command_buffer/service/in_process_command_buffer.h"
 #include "ui/gfx/vector2d_f.h"
 
 namespace content {
 class SynchronousCompositor;
 class WebContents;
 }
 
 typedef void* EGLContext;
 class SkCanvas;
 
@@ skipping 65 matching lines @@
   virtual void SetRootLayerPageScaleFactor(float page_scale_factor) OVERRIDE;
   virtual void SetRootLayerScrollableSize(gfx::SizeF scrollable_size) OVERRIDE;
   virtual void DidOverscroll(gfx::Vector2dF accumulated_overscroll,
                              gfx::Vector2dF latest_overscroll_delta,
                              gfx::Vector2dF current_fling_velocity) OVERRIDE;
 
   void WebContentsGone();
   bool RequestProcessGL();
 
  private:
+  class DeferredGpuCommandService : public gpu::InProcessCommandBuffer::Service {
+   public:
+    DeferredGpuCommandService();
+    virtual ~DeferredGpuCommandService();

[boliu, 2014/02/08 18:55:54]

Destructor needs to be protected. Also missing a few instance vars. Also I
prefer not nesting classes...

I uploaded https://codereview.chromium.org/153583009/ which you can patch in on
top to make this compile.

[no sievers, 2014/02/12 03:09:15]

Thanks! Done.

+
+    virtual void ScheduleTask(const base::Closure& task) OVERRIDE;
+    virtual void ScheduleIdleWork(const base::Closure& task) OVERRIDE;
+
+    void RunTasks();
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(DeferredGpuCommandService);
+  };
+
   // Checks the continuous invalidate and block invalidate state, and schedule
   // invalidates appropriately. If |invalidate_ignore_compositor| is true,
   // then send a view invalidate regardless of compositor expectation.
   void EnsureContinuousInvalidation(
       AwDrawGLInfo* draw_info,
       bool invalidate_ignore_compositor);
   bool DrawSWInternal(jobject java_canvas,
                       const gfx::Rect& clip_bounds);
   bool CompositeSW(SkCanvas* canvas);
 
@@ skipping 69 matching lines @@
 
   // Used to prevent rounding errors from accumulating enough to generate
   // visible skew (especially noticeable when scrolling up and down in the same
   // spot over a period of time).
   gfx::Vector2dF overscroll_rounding_error_;
 
   GLViewRendererManager::Key manager_key_;
 
   content::SynchronousCompositorMemoryPolicy memory_policy_;
 
+  scoped_refptr<DeferredGpuCommandService> gl_queue_;
+
   DISALLOW_COPY_AND_ASSIGN(InProcessViewRenderer);
 };
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_BROWSER_IN_PROCESS_VIEW_RENDERER_H_