Issue 143023002: Use a WebURL type for url parameter in registerProtocolHandler()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143023002: Use a WebURL type for url parameter in registerProtocolHandler() (Closed)

Created:
6 years, 11 months ago by gyuyoung-inactive

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use a WebURL type for url parameter in registerProtocolHandler() The registerProtocolHandler() of WebViewClient starts to use WebURL type for parameters related to url. Thus, content layer also needs to use WebURL parameter by the change. BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246326

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	content/renderer/render_view_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	content/renderer/render_view_impl.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gyuyoung-inactive

Jochen, it looks WebURL is more useful for url parameter. So, this cl change to ...

6 years, 11 months ago (2014-01-20 06:25:15 UTC) #1

gyuyoung-inactive

On 2014/01/22 11:31:38, jochen wrote: > lgtm Thanks !

6 years, 11 months ago (2014-01-22 11:57:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/143023002/1

6 years, 11 months ago (2014-01-22 11:57:53 UTC) #4

Message was sent while issue was closed.

Change committed as 246326

Expand Messages | Collapse Messages