Issue 14302003: Revert 194371

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14302003: Revert 194371 (Closed)

Created:
7 years, 8 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 8 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 194371 Looks like its breaking blink build. Contact jchaffraix for more info. > Refactor android specific code in AudioManagerBase class. > > Move android specific code into AudioManagerAndroid class. > > Contributed by leozwang@chromium.org (https://chromiumcodereview.appspot.com/14265014/). > > BUG=231468 > > Review URL: https://codereview.chromium.org/14053012 TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194407

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -86 lines)			Patch
M	media/audio/android/audio_manager_android.h	View	4 chunks	+0 lines, -17 lines	0 comments	Download
M	media/audio/android/audio_manager_android.cc	View	4 chunks	+0 lines, -62 lines	0 comments	Download
M	media/audio/audio_manager_base.h	View	4 chunks	+19 lines, -4 lines	0 comments	Download
M	media/audio/audio_manager_base.cc	View	9 chunks	+58 lines, -0 lines	0 comments	Download
M	media/base/android/media_jni_registrar.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

7 years, 8 months ago (2013-04-16 22:05:48 UTC) #3

Message was sent while issue was closed.

The real culprit is
https://src.chromium.org/viewvc/chrome?view=rev&revision=194378. I will reland
https://src.chromium.org/viewvc/chrome?view=rev&revision=194371.

Expand Messages | Collapse Messages