Issue 1430193002: Fix another race.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1430193002: Fix another race. (Closed)

Created:
5 years, 1 month ago by iannucci

Modified:
5 years, 1 month ago

Reviewers:
dnj, Vadim Sh., estaab

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae.git@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

Fix another race. R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/0cdf8c1ec3437329d4d2e0a825896fae3966b200

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	impl/memory/datastore_data.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vadim Sh.

I don't understand why this is a race (when everything is under the lock), but ...

5 years, 1 month ago (2015-11-07 00:39:07 UTC) #2

iannucci

On 2015/11/07 at 00:39:07, vadimsh wrote: > I don't understand why this is a race ...

5 years, 1 month ago (2015-11-07 00:40:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430193002/1

5 years, 1 month ago (2015-11-07 00:41:08 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-07 00:42:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/0cdf8c1ec3437329d4d2e0a825896fae3966b200

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages