Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1430153003: Moved the *PaintedLayerDelegates from ink_drop_animation.cc to ink_drop_painted_layer_delegates.h. (Closed)

Created:
5 years, 1 month ago by bruthig
Modified:
5 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved the *PaintedLayerDelegates from ink_drop_animation.cc to ink_drop_painted_layer_delegates.h. This CL promotes the *PaintedLayerDelegates from the ink_drop_animation.cc file to the ink_drop_painted_layer_delegates.(h|cc) in order to be reusable. Pre-requisite CL for https://codereview.chromium.org/1430153003/ BUG=537238 Committed: https://crrev.com/a07c1b3adfa6905b340240a75070f7436318b5c6 Cr-Commit-Position: refs/heads/master@{#358385}

Patch Set 1 #

Patch Set 2 : Actually added the new files to the branch/CL. #

Total comments: 4

Patch Set 3 : Added use of BasePaintedLayerDelegate::GetCenterPoint(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -120 lines) Patch
M ui/views/animation/ink_drop_animation.cc View 1 2 4 chunks +9 lines, -120 lines 0 comments Download
A ui/views/animation/ink_drop_painted_layer_delegates.h View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
A ui/views/animation/ink_drop_painted_layer_delegates.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bruthig
sadrul@, can you PTAL?
5 years, 1 month ago (2015-11-06 16:22:33 UTC) #3
sadrul
lgtm https://codereview.chromium.org/1430153003/diff/20001/ui/views/animation/ink_drop_painted_layer_delegates.h File ui/views/animation/ink_drop_painted_layer_delegates.h (right): https://codereview.chromium.org/1430153003/diff/20001/ui/views/animation/ink_drop_painted_layer_delegates.h#newcode4 ui/views/animation/ink_drop_painted_layer_delegates.h:4: #ifndef UI_VIEWS_ANIMATION_INK_DROP_PAINTED_LAYER_DELEGATES_H_ newline before https://codereview.chromium.org/1430153003/diff/20001/ui/views/animation/ink_drop_painted_layer_delegates.h#newcode26 ui/views/animation/ink_drop_painted_layer_delegates.h:26: virtual gfx::PointF ...
5 years, 1 month ago (2015-11-06 17:39:15 UTC) #4
bruthig
https://codereview.chromium.org/1430153003/diff/20001/ui/views/animation/ink_drop_painted_layer_delegates.h File ui/views/animation/ink_drop_painted_layer_delegates.h (right): https://codereview.chromium.org/1430153003/diff/20001/ui/views/animation/ink_drop_painted_layer_delegates.h#newcode4 ui/views/animation/ink_drop_painted_layer_delegates.h:4: #ifndef UI_VIEWS_ANIMATION_INK_DROP_PAINTED_LAYER_DELEGATES_H_ On 2015/11/06 17:39:14, sadrul wrote: > newline ...
5 years, 1 month ago (2015-11-06 18:51:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430153003/40001
5 years, 1 month ago (2015-11-06 18:52:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 20:54:48 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 20:55:28 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a07c1b3adfa6905b340240a75070f7436318b5c6
Cr-Commit-Position: refs/heads/master@{#358385}

Powered by Google App Engine
This is Rietveld 408576698