chrome/renderer/resources/extensions/test_custom_bindings.js - Issue 14301016: Fix a couple of bugs relating to sending Tab info with chrome.runtime.connect and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/test_custom_bindings.js

Issue 14301016: Fix a couple of bugs relating to sending Tab info with chrome.runtime.connect and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/message_service.cc ('K') | « chrome/renderer/resources/extensions/miscellaneous_bindings.js ('k') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/test_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/test_custom_bindings.js b/chrome/renderer/resources/extensions/test_custom_bindings.js

index a878c0669e96538b194e18e0eae90388d21d9d4e..d46d5ebfe543813c84c57f0e5a7700c740f7d0ab 100644

--- a/chrome/renderer/resources/extensions/test_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/test_custom_bindings.js

@@ -11,6 +11,7 @@ var chrome = requireNative('chrome').GetChrome();

var GetExtensionAPIDefinitions =

requireNative('apiDefinitions').GetExtensionAPIDefinitions;

var GetAvailability = requireNative('v8_context').GetAvailability;

+var json = require('json');

binding.registerCustomHook(function(api) {

var chromeTest = api.compiledApi;

@@ -181,8 +182,8 @@ binding.registerCustomHook(function(api) {

if (typeof(expected) == 'object') {

if (!chromeTest.checkDeepEq(expected, actual)) {

chromeTest.fail(error_msg +

- "\nActual: " + JSON.stringify(actual) +

- "\nExpected: " + JSON.stringify(expected));

+ "\nActual: " + json.stringify(actual) +

+ "\nExpected: " + json.stringify(expected));

}

return;

}