Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 14301016: Fix a couple of bugs relating to sending Tab info with chrome.runtime.connect and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 031422824dbb78aecbc70878e09673b2ffab4f19..a8b863f9d855d68d6ea79a41e9429ee8a2826445 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -542,15 +542,15 @@ void Dispatcher::OnMessageInvoke(const std::string& extension_id,
}
}
-void Dispatcher::OnDispatchOnConnect(int target_port_id,
- const std::string& channel_name,
- const std::string& tab_json,
- const std::string& source_extension_id,
- const std::string& target_extension_id) {
+void Dispatcher::OnDispatchOnConnect(
+ int target_port_id,
+ const std::string& channel_name,
+ const base::DictionaryValue& source_tab,
+ const ExtensionMsg_ExternalConnectionInfo& info) {
MiscellaneousBindings::DispatchOnConnect(
v8_context_set_.GetAll(),
- target_port_id, channel_name, tab_json,
- source_extension_id, target_extension_id,
+ target_port_id, channel_name, source_tab,
+ info.source_id, info.target_id, info.source_url,
NULL); // All render views.
}

Powered by Google App Engine
This is Rietveld 408576698