Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14301005: Android: Use a different socketname for devtools in content_browsertests. (Closed)

Created:
7 years, 8 months ago by nilesh
Modified:
7 years, 8 months ago
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, mnaganov (inactive)
Visibility:
Public.

Description

Android: Use a different socketname for devtools in content_browsertests. Sharing the same socket name causes tests to crash if content_browsertests process is still running while running content_shell instrumentation tests. Examples failures can be seen on the tryjobs for: https://codereview.chromium.org/13445005/ BUG=230113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194473

Patch Set 1 #

Total comments: 4

Patch Set 2 : Using kRemoteDebuggingSocketName #

Total comments: 2

Patch Set 3 : CONTENT_EXPORT #

Patch Set 4 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -39 lines) Patch
M chrome/browser/android/dev_tools_server.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 1 4 chunks +10 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell_browser_main_parts.cc View 2 chunks +1 line, -20 lines 0 comments Download
M content/shell/shell_devtools_delegate.h View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M content/shell/shell_devtools_delegate.cc View 2 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nilesh
joi: content/public/common/ jochen: content/shell
7 years, 8 months ago (2013-04-16 19:33:28 UTC) #1
Jói
LGTM for content/public
7 years, 8 months ago (2013-04-16 19:35:28 UTC) #2
pfeldman
lgtm
7 years, 8 months ago (2013-04-16 19:39:13 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/14301005/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/14301005/diff/1/content/public/common/content_switches.h#newcode175 content/public/common/content_switches.h:175: extern const char kRemoteDebuggingSocketName[]; this should go into content/shell/shell_switches.* ...
7 years, 8 months ago (2013-04-16 19:39:29 UTC) #4
nilesh
jochen: PTAL https://codereview.chromium.org/14301005/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/14301005/diff/1/content/public/common/content_switches.h#newcode175 content/public/common/content_switches.h:175: extern const char kRemoteDebuggingSocketName[]; On 2013/04/16 19:39:29, ...
7 years, 8 months ago (2013-04-16 20:50:53 UTC) #5
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/14301005/diff/13001/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/14301005/diff/13001/content/public/common/content_switches.h#newcode175 content/public/common/content_switches.h:175: extern const char kRemoteDebuggingSocketName[]; nit. CONTENT_EXPORT
7 years, 8 months ago (2013-04-16 20:52:51 UTC) #6
nilesh
https://codereview.chromium.org/14301005/diff/13001/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/14301005/diff/13001/content/public/common/content_switches.h#newcode175 content/public/common/content_switches.h:175: extern const char kRemoteDebuggingSocketName[]; On 2013/04/16 20:52:52, jochen wrote: ...
7 years, 8 months ago (2013-04-16 20:57:42 UTC) #7
nilesh
7 years, 8 months ago (2013-04-16 22:45:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 manually as r194473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698