Issue 1430093006: EDK: Split the mojo_edk_system_unittests target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1430093006: EDK: Split the mojo_edk_system_unittests target. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Split the mojo_edk_system_unittests target. For now, just split by directory. Possibly/probably, they should be split even further (this is especially true of the tests in embedder, where there are multiple targets/source sets -- but possibly the .cc/.h files should also be relocated). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c2ad309214597985b74154163f207c41d2301a13

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -30 lines)			Patch
M	mojo/BUILD.gn	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A	mojo/edk/BUILD.gn	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	mojo/edk/embedder/BUILD.gn	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	mojo/edk/system/BUILD.gn	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	mojo/edk/system/test/BUILD.gn	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	mojo/edk/util/BUILD.gn	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	mojo/tools/data/unittests	View	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-11-09 21:43:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2ad309214597985b74154163f207c41d2301a13 (presubmit successful).

Expand Messages | Collapse Messages