components/domain_reliability.gypi - Issue 1430043002: Support script response files in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability.gypi

Issue 1430043002: Support script response files in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment, random build fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/domain_reliability.gypi

diff --git a/components/domain_reliability.gypi b/components/domain_reliability.gypi

index 4412b612aeb5a62e4e15a1c9d6ee9f0a94d0ae56..8f2f12a60d00ea8b8b40b441fe3e58c13ef8baaf 100644

--- a/components/domain_reliability.gypi

+++ b/components/domain_reliability.gypi

@@ -72,9 +72,9 @@

# bake_in_configs.py will read the filenames out of it manually.

'action': ['python',

'<(bake_in_configs_script)',

- '.',

- 'domain_reliability/baked_in_configs.gypi',

- '<(baked_in_configs_cc)'],

+ '--gypi-relative-to=.',

+ '--gypi-file=domain_reliability/baked_in_configs.gypi',

+ '--output=<(baked_in_configs_cc)'],

'process_outputs_as_sources': 1,

'message': 'Baking in Domain Reliability configs',

« no previous file with comments | « chrome/installer/mini_installer/BUILD.gn ('k') | components/domain_reliability/BUILD.gn » ('j') | no next file with comments »