Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 143003030: Removing using namespace std as per Blink coding guidelines (Closed)

Created:
6 years, 10 months ago by naveensg
Modified:
6 years, 10 months ago
Reviewers:
darktears, eae, eseidel
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removing using namespace std as per Blink coding guidelines As per Blink coding guidelines as mentioned in http://dev.chromium.org/blink/coding-style I made the following changes in loader and fetch modules Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M Source/core/fetch/ImageResource.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/loader/CrossOriginPreflightResultCache.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
naveensg
Pls review the patch. Thnx
6 years, 10 months ago (2014-02-11 11:32:08 UTC) #1
naveensg
6 years, 10 months ago (2014-02-11 11:36:21 UTC) #2
eseidel
lgtm
6 years, 10 months ago (2014-02-11 11:42:09 UTC) #3
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 10 months ago (2014-02-11 11:42:14 UTC) #4
eseidel
lgtm I have verified that naveen has signed the CLA.
6 years, 10 months ago (2014-02-11 11:43:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naveensg@samsung.com/143003030/1
6 years, 10 months ago (2014-02-11 11:43:44 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 13:42:34 UTC) #7
Message was sent while issue was closed.
Change committed as 166924

Powered by Google App Engine
This is Rietveld 408576698