Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 143003024: Fix geolocation timestamp to return in milliseconds when emulating in inspector. (Closed)

Created:
6 years, 10 months ago by maheshkk
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix geolocation timestamp to return in milliseconds when emulating in inspector. BUG=279751 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167873

Patch Set 1 #

Patch Set 2 : Adding test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M LayoutTests/inspector/geolocation-emulation-tests.html View 1 2 chunks +28 lines, -5 lines 0 comments Download
M LayoutTests/inspector/geolocation-emulation-tests-expected.txt View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/geolocation/GeolocationInspectorAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
maheshkk
Please review.
6 years, 10 months ago (2014-02-06 23:10:36 UTC) #1
maheshkk
trivial patch review. Thanks!
6 years, 10 months ago (2014-02-07 19:03:22 UTC) #2
abarth-chromium
Test?
6 years, 10 months ago (2014-02-08 01:09:43 UTC) #3
maheshkk
On 2014/02/08 01:09:43, abarth wrote: > Test? Done. Sorry this took sometime, there were not ...
6 years, 10 months ago (2014-02-25 19:57:55 UTC) #4
abarth-chromium
LGTM Thanks for the test!
6 years, 10 months ago (2014-02-26 05:50:07 UTC) #5
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 10 months ago (2014-02-26 06:22:18 UTC) #6
maheshkk
On 2014/02/26 05:50:07, abarth wrote: > LGTM > > Thanks for the test! Sure. Thank ...
6 years, 10 months ago (2014-02-26 06:22:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/143003024/70001
6 years, 10 months ago (2014-02-26 06:22:30 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 09:11:08 UTC) #9
Message was sent while issue was closed.
Change committed as 167873

Powered by Google App Engine
This is Rietveld 408576698