chrome/browser/ui/webui/options/language_options_handler_common.cc - Issue 143003020: Move TranslateLanguageList to the Translate component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 143003020: Move TranslateLanguageList to the Translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removeDelegate

Patch Set: rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_options_handler_common.cc

diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc

index 5c1131d660917698621d7a269e4f51023347a0cd..4059e1e565a5257ba84fbf9c101289b9cdddeb8b 100644

--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc

+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc

@@ -27,6 +27,7 @@

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/spellcheck_common.h"

+#include "components/translate/core/browser/translate_download_manager.h"

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_ui.h"

#include "grit/chromium_strings.h"

@@ -130,7 +131,7 @@ void LanguageOptionsHandlerCommon::GetLocalizedValues(

default_target_language);

std::vector<std::string> languages;

- TranslateManager::GetSupportedLanguages(&languages);

+ TranslateDownloadManager::GetSupportedLanguages(&languages);

base::ListValue* languages_list = new base::ListValue();

for (std::vector<std::string>::iterator it = languages.begin();