Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3441)

Unified Diff: chrome/browser/translate/translate_manager.h

Issue 143003020: Move TranslateLanguageList to the Translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removeDelegate
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_language_list.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager.h
diff --git a/chrome/browser/translate/translate_manager.h b/chrome/browser/translate/translate_manager.h
index c568ee7792f71d56d00fb68f63cf12d2e5e418c5..eb1cc65dcbaaf4ceda415ea3033e4089751d341d 100644
--- a/chrome/browser/translate/translate_manager.h
+++ b/chrome/browser/translate/translate_manager.h
@@ -13,7 +13,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
-#include "base/time/time.h"
#include "chrome/browser/ui/translate/translate_bubble_model.h"
#include "components/translate/core/common/translate_errors.h"
#include "content/public/browser/notification_observer.h"
@@ -28,9 +27,7 @@ class Profile;
struct ShortcutConfiguration;
class TranslateAcceptLanguages;
struct TranslateErrorDetails;
-struct TranslateEventDetails;
class TranslateInfoBarDelegate;
-class TranslateLanguageList;
class TranslateScript;
namespace content {
@@ -56,25 +53,6 @@ class TranslateManager : public content::NotificationObserver {
// Returns true if the URL can be translated.
static bool IsTranslatableURL(const GURL& url);
- // Fills |languages| with the list of languages that the translate server can
- // translate to and from.
- static void GetSupportedLanguages(std::vector<std::string>* languages);
-
- // Returns the last-updated time when Chrome receives a language list from a
- // Translate server. Returns null time if Chrome hasn't received any lists.
- static base::Time GetSupportedLanguagesLastUpdated();
-
- // Returns the language code that can be used with the Translate method for a
- // specified |chrome_locale|.
- static std::string GetLanguageCode(const std::string& chrome_locale);
-
- // Returns true if |language| is supported by the translation server.
- static bool IsSupportedLanguage(const std::string& language);
-
- // Returns true if |language| is supported by the translation server as a
- // alpha language.
- static bool IsAlphaLanguage(const std::string& language);
-
// Returns true if |language| is an Accept language for the user profile.
static bool IsAcceptLanguage(Profile* profile, const std::string& language);
@@ -98,11 +76,6 @@ class TranslateManager : public content::NotificationObserver {
// used only for tests.
static void SetUseInfobar(bool value);
- // Let the caller decide if and when we should fetch the language list from
- // the translate server. This is a NOOP if switches::kDisableTranslate is set
- // or if prefs::kEnableTranslate is set to false.
- void FetchLanguageListFromTranslateServer(PrefService* prefs);
-
// Allows caller to cleanup pending URLFetcher objects to make sure they
// get released in the appropriate thread... Mainly for tests.
void CleanupPendingUlrFetcher();
@@ -148,17 +121,12 @@ class TranslateManager : public content::NotificationObserver {
const LanguageDetectionDetails& details) = 0;
virtual void OnTranslateError(
const TranslateErrorDetails& details) = 0;
- virtual void OnTranslateEvent(
- const TranslateEventDetails& details) = 0;
};
// Adds/removes observer.
void AddObserver(Observer* obs);
void RemoveObserver(Observer* obs);
- // Notifies to the observers when translate event happens.
- void NotifyTranslateEvent(const TranslateEventDetails& details);
-
protected:
TranslateManager();
@@ -230,9 +198,6 @@ class TranslateManager : public content::NotificationObserver {
// List of registered observers.
ObserverList<Observer> observer_list_;
- // An instance of TranslateLanguageList which manages supported language list.
- scoped_ptr<TranslateLanguageList> language_list_;
-
// An instance of TranslateScript which manages JavaScript source for
// Translate.
scoped_ptr<TranslateScript> script_;
« no previous file with comments | « chrome/browser/translate/translate_language_list.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698