Issue 143003016: More code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143003016: More code problems detected by cppcheck (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
Stephen Chennney, Inactive, abarth-chromium

CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

More code problems detected by cppcheck Another round this time running cppcheck with style flag on trunk codebase. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165672

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -4 lines)			Patch
M	Source/core/css/RuleFeature.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/parser/HTMLTreeBuilder.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderGrid.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

Small fixes. The compiler will probably filter out the unneeded breaks but I think it ...

6 years, 11 months ago (2014-01-23 17:54:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/143003016/1

6 years, 11 months ago (2014-01-23 20:55:31 UTC) #3

Message was sent while issue was closed.

Change committed as 165672

Expand Messages | Collapse Messages