Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Issue 143003012: Revert of cc: Remove WorkerPool class and instead use TaskGraphRunner directly. (Closed)

Created:
6 years, 11 months ago by Mattias Nissler (ping if slow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert of cc: Remove WorkerPool class and instead use TaskGraphRunner directly. (https://codereview.chromium.org/141163019/) Reason for revert: Bad file mode for task_graph_runner.h: /b/build/slave/Linux_ChromiumOS/build/src/cc/resources/task_graph_runner.h: Must not have executable bit set http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/31393/steps/check_perms/logs/stdio Original issue's description: > cc: Remove WorkerPool class and instead use TaskGraphRunner directly. > > Removes the unnecessary WorkerPool layer. This makes the job > of the TaskGraphRunner more clear and will allow us to remove > some complexity and unnecessary heap allocations from the > RasterWorkerPool code in follow up patches. > > Also moves the kNumRasterTasks switch to content/. > > Refactor only, no changes in behavior. > > BUG=331844 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246284 TBR=vmpstr@chromium.org,alokp@chromium.org,sohan.jyoti@samsung.com,jamesr@chromium.org,piman@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG=331844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1583 lines, -1439 lines) Patch
M cc/base/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/cc.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/image_raster_worker_pool.h View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M cc/resources/picture_pile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 6 chunks +5 lines, -8 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 11 chunks +39 lines, -63 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 15 chunks +45 lines, -116 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D cc/resources/task_graph_runner.h View 1 chunk +0 lines, -235 lines 0 comments Download
D cc/resources/task_graph_runner.cc View 1 chunk +0 lines, -397 lines 0 comments Download
D cc/resources/task_graph_runner_perftest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D cc/resources/task_graph_runner_unittest.cc View 1 chunk +0 lines, -347 lines 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A cc/resources/worker_pool.h View 1 chunk +146 lines, -0 lines 0 comments Download
A cc/resources/worker_pool.cc View 1 chunk +601 lines, -0 lines 0 comments Download
A cc/resources/worker_pool_perftest.cc View 1 chunk +239 lines, -0 lines 0 comments Download
A cc/resources/worker_pool_unittest.cc View 1 chunk +465 lines, -0 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mattias Nissler (ping if slow)
Created Revert of cc: Remove WorkerPool class and instead use TaskGraphRunner directly.
6 years, 11 months ago (2014-01-22 11:40:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/143003012/1
6 years, 11 months ago (2014-01-22 11:40:05 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 11:41:01 UTC) #3
Message was sent while issue was closed.
Change committed as 246298

Powered by Google App Engine
This is Rietveld 408576698