Refactor fast path for empty constant strings in BinaryOp.

Refactor fast path for empty constant strings in BinaryOp.

R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18742

[Benedikt Meurer, 2014-01-21 10:34:39]

Hey Michael,
Here's a simple refactoring to ensure that the fast path for empty constants
strings is checked first.
PTAL
-- Benedikt

[mvstanton, 2014-01-21 15:52:26]

Small nit, and LGTM.

https://codereview.chromium.org/143003005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/143003005/diff/1/src/hydrogen.cc#newcode8985
src/hydrogen.cc:8985: ConsString::kMinLength) ||
Can ConsString::kMinLength be indented 2 spaces? It would better attach it to
the expression on the line above.

https://codereview.chromium.org/143003005/diff/1/src/hydrogen.cc#newcode8989
src/hydrogen.cc:8989: ConsString::kMinLength)) {
Same.

[Benedikt Meurer, 2014-01-22 12:29:54]

https://codereview.chromium.org/143003005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/143003005/diff/1/src/hydrogen.cc#newcode8985
src/hydrogen.cc:8985: ConsString::kMinLength) ||
On 2014/01/21 15:52:26, mvstanton wrote:
> Can ConsString::kMinLength be indented 2 spaces? It would better attach it to
> the expression on the line above.

Done.

https://codereview.chromium.org/143003005/diff/1/src/hydrogen.cc#newcode8989
src/hydrogen.cc:8989: ConsString::kMinLength)) {
On 2014/01/21 15:52:26, mvstanton wrote:
> Same.

Done.

[Benedikt Meurer, 2014-01-22 12:30:07]

Committed patchset #2 manually as r18742 (presubmit successful).