chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm - Issue 1430023002: Enable AutoResize for Constrained Web Dialogs for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm

Issue 1430023002: Enable AutoResize for Constrained Web Dialogs for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per erikchen@'s comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm

index 3c71f00e0a19063454872beb63e876e6bea5a0f5..6e7d3f191fc0c265e3014b5379114c18de225a10 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm

@@ -27,4 +27,14 @@

[super updateSheetPosition];

}

+- (void)resizeWithNewSize:(NSSize)size {

+ [customWindow_ setContentSize:size];

+ // self's updateSheetPosition() sets |customWindow_|'s contentSize to a

+ // fixed dialog size. Here, we want to resize to |size| instead. Use

+ // super rather than self to bypass the setContentSize() call for the fixed

+ // size.

+ [super updateSheetPosition];

@end