Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1430013002: Parse webkit-text-stroke shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse webkit-text-stroke shorthand in CSSPropertyParser with CSSParserTokens Move webkit-text-stroke shorthand property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. BUG=499780 Committed: https://crrev.com/18669d2fac93b3f8880c80277aa38d400f4f4574 Cr-Commit-Position: refs/heads/master@{#359423}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase + fix test expectation #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/remove-shorthand-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL. The different test expectation is because consumeShorthandGreedily adds properties according the the shorthand array, ...
5 years, 1 month ago (2015-11-09 16:45:42 UTC) #4
Timothy Loh
On 2015/11/09 16:45:42, rwlbuis wrote: > PTAL. The different test expectation is because consumeShorthandGreedily adds ...
5 years, 1 month ago (2015-11-12 20:36:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430013002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430013002/80001
5 years, 1 month ago (2015-11-12 21:40:07 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 1 month ago (2015-11-12 23:12:22 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 23:13:12 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/18669d2fac93b3f8880c80277aa38d400f4f4574
Cr-Commit-Position: refs/heads/master@{#359423}

Powered by Google App Engine
This is Rietveld 408576698