Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1429953005: PPC: [runtime] Drop redundant %CharFromCode runtime entry. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Drop redundant %CharFromCode runtime entry. Port 2b4cb2a14011404e7d20341bdc91d890a4584a18 Original commit message: The %StringCharFromCode and %CharFromCode runtime function perform exactly the same task, so we need only one of them. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/bdb04d5b8bba51ffaaeb229a2359bce503f2d1a2 Cr-Commit-Position: refs/heads/master@{#31904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-09 20:31:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429953005/1
5 years, 1 month ago (2015-11-09 20:31:43 UTC) #3
michael_dawson
On 2015/11/09 20:31:43, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 1 month ago (2015-11-09 20:41:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 21:00:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429953005/1
5 years, 1 month ago (2015-11-09 21:01:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 21:02:33 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 21:02:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdb04d5b8bba51ffaaeb229a2359bce503f2d1a2
Cr-Commit-Position: refs/heads/master@{#31904}

Powered by Google App Engine
This is Rietveld 408576698