Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1429953004: win: Use FormatMessage[W]() instead of FormatMessageA() for logging (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

win: Use FormatMessage[W]() instead of FormatMessageA() for logging FormatMessageA() returns a message in the system's native code page, but the logging interface expects and assumes UTF-8. UTF-8 can be obtained by calling the UTF-16 FormatMessage() variant and converting. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/06e0fa1309a04bca3d785cc5635840366ba73682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M base/logging.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This includes two other changes: - It switches the GetLastError() code formatting to decimal, to ...
5 years, 1 month ago (2015-11-09 20:25:53 UTC) #2
scottmg
lgtm
5 years, 1 month ago (2015-11-09 20:43:14 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-11-09 20:48:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06e0fa1309a04bca3d785cc5635840366ba73682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698