Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1429933006: Replaced deprecated os.path.walk usage with os.walk

Created:
5 years, 1 month ago by AWhetter
Modified:
3 years, 8 months ago
Reviewers:
methane
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Replaced deprecated os.path.walk usage (see https://docs.python.org/2/library/os.path.html?highlight=os.path.walk#os.path.walk) with os.walk I've also removed Collector because os.walk can visit directories bottom-up, so Collector is not needed anymore.

Patch Set 1 #

Patch Set 2 : Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M test/lib/TestCmd.py View 4 chunks +34 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
AWhetter
5 years, 1 month ago (2015-11-06 20:41:54 UTC) #2
AWhetter
4 years, 8 months ago (2016-04-09 15:37:41 UTC) #3
methane
3 years, 8 months ago (2017-04-06 10:07:44 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698