chrome/browser/extensions/tab_helper.cc - Issue 142993002: Remove unused members from WebApplicationInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 142993002: Remove unused members from WebApplicationInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/tab_helper.cc

diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc

index c38dc4a69635f92719b066cee72978a7941c6c94..f6c1495dc6b799d748b08889e4007b62aa4549e8 100644

--- a/chrome/browser/extensions/tab_helper.cc

+++ b/chrome/browser/extensions/tab_helper.cc

@@ -355,9 +355,6 @@ void TabHelper::FinishCreateHostedApp(

if (install_info.title.empty())

install_info.title = base::UTF8ToUTF16(install_info.app_url.spec());

- install_info.urls.push_back(install_info.app_url);

- install_info.is_bookmark_app = true;

// Add the downloaded icons. Extensions only allow certain icon sizes. First

// populate icons that match the allowed sizes exactly and then downscale

// remaining icons to the closest allowed size that doesn't yet have an icon.