Remove unused members from WebApplicationInfo.

Remove unused members from WebApplicationInfo.

Many of the members from WebApplicationInfo were in place to support
crx-less hosted apps. Since crx-less apps have been removed, we can
clean up references to them and repurpose convert_web_app.cc to be
solely for generating bookmark apps.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247870

[benwells, 2014-01-21 22:42:12]

https://codereview.chromium.org/142993002/diff/1/chrome/common/extensions/man...
File chrome/common/extensions/manifest_handlers/app_launch_info.cc (right):

https://codereview.chromium.org/142993002/diff/1/chrome/common/extensions/man...
chrome/common/extensions/manifest_handlers/app_launch_info.cc:181: // extents.
Isn't this from another change, and no longer needed?

[calamity, 2014-01-24 06:06:12]

https://codereview.chromium.org/142993002/diff/1/chrome/common/extensions/man...
File chrome/common/extensions/manifest_handlers/app_launch_info.cc (right):

https://codereview.chromium.org/142993002/diff/1/chrome/common/extensions/man...
chrome/common/extensions/manifest_handlers/app_launch_info.cc:181: // extents.
On 2014/01/21 22:42:13, benwells wrote:
> Isn't this from another change, and no longer needed?

My bad, branch management. Removed.

[benwells, 2014-01-27 10:30:16]

lgtm

https://codereview.chromium.org/142993002/diff/70001/chrome/browser/extension...
File chrome/browser/extensions/convert_web_app.cc (right):

https://codereview.chromium.org/142993002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/convert_web_app.cc:161: extension_flags |=
Extension::FROM_BOOKMARK;
nit: above two lines can be combined.

[calamity, 2014-01-28 05:41:10]

+sky for chrome/common/web_application_info.* OWNERS.

[sky, 2014-01-28 14:57:46]

LGTM

[calamity, 2014-01-29 00:14:51]

+dcheng@ for extension_messages.h OWNERS.

[dcheng, 2014-01-29 00:25:04]

lgtm

[commit-bot: I haz the power, 2014-01-29 01:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/142993002/70001

[commit-bot: I haz the power, 2014-01-29 01:41:24]

Failed to apply patch for chrome/browser/extensions/tab_helper.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/tab_helper.cc
  Hunk #1 FAILED at 355.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/tab_helper.cc.rej

Patch:       chrome/browser/extensions/tab_helper.cc
Index: chrome/browser/extensions/tab_helper.cc
diff --git a/chrome/browser/extensions/tab_helper.cc
b/chrome/browser/extensions/tab_helper.cc
index
c38dc4a69635f92719b066cee72978a7941c6c94..f6c1495dc6b799d748b08889e4007b62aa4549e8
100644
--- a/chrome/browser/extensions/tab_helper.cc
+++ b/chrome/browser/extensions/tab_helper.cc
@@ -355,9 +355,6 @@ void TabHelper::FinishCreateHostedApp(
   if (install_info.title.empty())
     install_info.title = base::UTF8ToUTF16(install_info.app_url.spec());
 
-  install_info.urls.push_back(install_info.app_url);
-  install_info.is_bookmark_app = true;
-
   // Add the downloaded icons. Extensions only allow certain icon sizes. First
   // populate icons that match the allowed sizes exactly and then downscale
   // remaining icons to the closest allowed size that doesn't yet have an icon.

[commit-bot: I haz the power, 2014-01-29 02:48:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/142993002/160001

[commit-bot: I haz the power, 2014-01-29 04:11:13]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2014-01-29 08:18:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/142993002/160001

[commit-bot: I haz the power, 2014-01-29 13:52:57]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2014-01-30 00:18:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/142993002/160001

[commit-bot: I haz the power, 2014-01-30 07:23:30]

Change committed as 247870