Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 14299007: Sends Updated when message center is closed. (Closed)

Created:
7 years, 8 months ago by Jun Mukai
Modified:
7 years, 8 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Sends Updated when message center is closed. Because open/close will change the notification status (read/shown), it should send Updated to the observers. BUG=232030 TEST=manually (see repro steps in the bug) R=dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194698

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M ui/message_center/message_center_impl.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/message_center/notification_list.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/message_center/notification_list.cc View 1 2 chunks +11 lines, -3 lines 0 comments Download
M ui/message_center/notification_list_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
7 years, 8 months ago (2013-04-16 21:07:21 UTC) #1
dewittj
lgtm with nits https://codereview.chromium.org/14299007/diff/1/ui/message_center/notification_list.cc File ui/message_center/notification_list.cc (right): https://codereview.chromium.org/14299007/diff/1/ui/message_center/notification_list.cc#newcode57 ui/message_center/notification_list.cc:57: std::set<std::string> dummy_ids; I don't love keeping ...
7 years, 8 months ago (2013-04-16 23:59:12 UTC) #2
Jun Mukai
https://codereview.chromium.org/14299007/diff/1/ui/message_center/notification_list.cc File ui/message_center/notification_list.cc (right): https://codereview.chromium.org/14299007/diff/1/ui/message_center/notification_list.cc#newcode57 ui/message_center/notification_list.cc:57: std::set<std::string> dummy_ids; On 2013/04/16 23:59:13, dewittj wrote: > I ...
7 years, 8 months ago (2013-04-17 01:04:43 UTC) #3
Jun Mukai
7 years, 8 months ago (2013-04-17 21:52:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r194698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698