Issue 14299005: Add support for zero-padded strings to WebMParser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14299005: Add support for zero-padded strings to WebMParser. (Closed)

Created:
7 years, 8 months ago by acolwell GONE FROM CHROMIUM

Modified:
7 years, 8 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for zero-padded strings to WebMParser. BUG=227416 TEST=WebMParserTest.ZeroPaddedStrings Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194607

Patch Set 2 : Fix mac build #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	media/webm/webm_parser.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
	M	media/webm/webm_parser_unittest.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

lgtm w/ compile failure nit nice test! https://codereview.chromium.org/14299005/diff/1/media/webm/webm_parser.cc File media/webm/webm_parser.cc (right): https://codereview.chromium.org/14299005/diff/1/media/webm/webm_parser.cc#newcode602 media/webm/webm_parser.cc:602: int length ...

7 years, 8 months ago (2013-04-16 21:01:00 UTC) #2

acolwell GONE FROM CHROMIUM

7 years, 8 months ago (2013-04-17 16:16:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r194607 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14299005: Add support for zero-padded strings to WebMParser. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix mac build #

Messages