Issue 14299003: Gamepad: Gamepads length should be maximum supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14299003: Gamepad: Gamepads length should be maximum supported. (Closed)

Created:
7 years, 8 months ago by teravest

Modified:
7 years, 8 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Gamepad: Gamepads length should be maximum supported. On Windows and Linux, the length of gamepads reported is always 4. On Mac, it's different, and varies based on the number of controllers that are connected. For consistency, this change makes Chromium report data for 4 controllers on Mac. Tested: Ran the gamepad example, and verified that it now reports 4 controllers. I connected a gamepad and it reported 1 connected and 3 disconnected. BUG=229586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194426

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

teravest

7 years, 8 months ago (2013-04-16 20:00:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194426 (presubmit successful).

Expand Messages | Collapse Messages