components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java - Issue 1429863008: [Cronet] Remove JSON serialization of CronetEngine.Builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

Issue 1429863008: [Cronet] Remove JSON serialization of CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('K') | « components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java ('k') | components/cronet/android/java/src/org/chromium/net/CronetEngineBuilderList.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

index a8f20ca2b79881ef969aac76b3a1c9121782c7fa..7572f30e00f8e1be45afd5faab37004300de7dca 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

@@ -6,6 +6,7 @@ package org.chromium.net;

import android.content.Context;

import android.os.Build;

+import android.text.TextUtils;

import org.chromium.base.annotations.UsedByReflection;

@@ -25,7 +26,7 @@ public class ChromiumUrlRequestFactory extends HttpUrlRequestFactory {

public ChromiumUrlRequestFactory(Context context, CronetEngine.Builder config) {

if (isEnabled()) {

String userAgent = config.getUserAgent();

- if (userAgent.isEmpty()) {

+ if (TextUtils.isEmpty(userAgent)) {

// Cannot use config.getDefaultUserAgent() as config.mContext may be null.

userAgent = new CronetEngine.Builder(context).getDefaultUserAgent();

}